Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS SNS Gateway #169

Merged
merged 7 commits into from
Feb 17, 2019
Merged

AWS SNS Gateway #169

merged 7 commits into from
Feb 17, 2019

Conversation

VaibhavPage
Copy link
Contributor

@VaibhavPage VaibhavPage commented Feb 16, 2019 •
edited
Loading

  • Extracting common webhook functionality
  • Simplifying existing webhook, storage-grid gateways
  • Adding AWS SNS gateway

#154

@VaibhavPage VaibhavPage added the enhancement New feature or request label Feb 16, 2019
@VaibhavPage VaibhavPage added this to the v0.8 milestone Feb 16, 2019
@VaibhavPage VaibhavPage marked this pull request as ready for review February 17, 2019 00:04
magaldima
magaldima approved these changes Feb 17, 2019
View reviewed changes
Copy link
Contributor

@magaldima magaldima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactor to common rest gateway looks good. 👍

@magaldima magaldima merged commit c98e35c into master Feb 17, 2019
@magaldima magaldima mentioned this pull request Feb 17, 2019
Closed
@VaibhavPage VaibhavPage deleted the aws-sns branch February 18, 2019 12:58
@VaibhavPage VaibhavPage mentioned this pull request Feb 28, 2019
Closed
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
@VaibhavPage @magaldima
AWS SNS Gateway (argoproj#169)
7929485 
* Added support for backoff option when making connections in stream gateways

* Extracting common webhook functionality

* Modified storage grid and webhook implementation to take advantage of common webhook functionality

* Added sns gateway implementation

* Enhancing sns gateway

* Update deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magaldima magaldima magaldima approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.
2 participants
@VaibhavPage @magaldima