Trigger resources without namespace can not be created

[dtaniwaki]

Describe the bug

I found omitting namespace in trigger resources causes an error in this line.

argo-events/sensors/trigger.go

Line 230 in a681180

return fmt.Errorf("failed to create resource object. err: %+v", err)

Here's the actual error log.

2019-03-08T11:01:48Z | error | msg: trigger failed to execute |  error="failed to create resource object. err: an empty namespace may not be set during creation" sensor-name:hdfs-sensor trigger-name:hdfs-workflow-trigger

To Reproduce

Omit namespace in your trigger resources.

Expected behavior

argo-events/pkg/apis/sensor/v1alpha1/types.go

Line 259 in ac66a69

// defaults to the service account namespace

This line describes the default namespace is the namespace of the service account. However, it seems the default namespace is not applied.

I think the namespace of the service account is hard to imagine. Should we use the namespace of the sensor, or default namespace?

Screenshots

N/A

Environment (please complete the following information):

• OS: macOS
• Browser: N/A
• Version: N/A

Additional context

N/A

[VaibhavPage]

Hmm... Somehow I thought this was taken care of. I think we should fall back to Sensor namespace mainly because many users install argo and argo-events in the same namespace.

[dtaniwaki]

I’ll fix it like so!