Handle empty namespace on trigger resources #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should verify codegen in CI to avoid unexpected diff in another PR. |
|
Agreed. |
VaibhavPage
previously approved these changes
Mar 12, 2019
|
Getting Failures:
|
VaibhavPage
approved these changes
Mar 13, 2019
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
* Set sensor namespace on trigger resources by default * Update OpenAPI gen * Update Gopkg.lock * Fix tests * Make condition easier to read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I set sensor's namespace as the default namespace of trigger resources, and added the tests.
I found OpenAPI spec is not updated when I executed
make openapi-gen, so the PR also includes OpenAPI spec update for some other PRs.Fixes #214