Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestMetricsWithWebhook fails #2993

Closed
BabisK opened this issue Jan 25, 2024 · 0 comments
Closed

TestMetricsWithWebhook fails #2993

BabisK opened this issue Jan 25, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@BabisK
Copy link
Contributor

BabisK commented Jan 25, 2024

Describe the bug
When executing the e2e test TestMetricsWithWebhook a assertion fails. The reason is that the test expects the URL https://not-existing.com/ to not respond. But it seems that this URL now responds with 404.

2024-01-25T20:54:40.342Z	INFO	argo-events.sensor	sensors/listener.go:433	Successfully processed trigger 'http-trigger'	{"sensorName": "e2e-test-metrics", "triggerName": "http-trigger", "triggerType": "HTTP", "triggeredBy": ["test-dep"], "triggeredByEvents": ["62666466616533632d306231382d343331392d623135362d323966353734303239343662"]}
error: context deadline exceeded    then.go:79: expected sensor pod log contains 'Failed to execute a trigger'
    then.go:129: Terminating port-forward for POD e2e-test-metrics-sensor-lnwt8-7546655b5f-c94fj
    panic.go:522: Deleting sensor e2e-test-metrics
    then.go:129: Terminating port-forward for POD e2e-test-metrics-webhook-eventsource-t7m6h-85f8779d8-dlpxh
    panic.go:522: Deleting event source e2e-test-metrics-webhook
    --- FAIL: TestFunctionalSuite/TestMetricsWithWebhook (21.43s)

To Reproduce
Steps to reproduce the behavior:

  1. Setup the test environment with k3d
  2. EventBusDriver=stan make TestMetricsWithWebhook

Expected behavior
The URL should not respond and the test would secceed.

Environment (please complete the following information):

  • Kubernetes: [k3d]
  • Argo Events: [master]

Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@BabisK BabisK added the bug Something isn't working label Jan 25, 2024
BabisK added a commit to BabisK/argo-events that referenced this issue Jan 25, 2024
…proj#2993)

This url is reserved by IANA and is expected to always fail resolution.

Signed-off-by: Babis Kaidos <[email protected]>
whynowy pushed a commit that referenced this issue Jan 27, 2024
@whynowy whynowy closed this as completed Feb 12, 2024
whynowy pushed a commit that referenced this issue Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants