Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventSource deployment strategy and replicas control #752

Closed
whynowy opened this issue Jul 17, 2020 · 0 comments · Fixed by #755
Closed

EventSource deployment strategy and replicas control #752

whynowy opened this issue Jul 17, 2020 · 0 comments · Fixed by #755
Milestone

Comments

@whynowy
Copy link
Member

whynowy commented Jul 17, 2020

Is your feature request related to a problem? Please describe.
The default EventSource deployment strategy is rollingUpdate, it works for most of event sources, but doesn't for the ones who do not allow multiple clients running at the same time, for example, multiple NATS clients with same client ID are not allowed.

Same problem applies for replicas.

Describe the solution you'd like
For the eventsources like that,

  1. use recreate strategy;
  2. replicas always set to 1.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant