feat: Different deployment update strategy for different event sources #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whynowy
commented
Jul 17, 2020
| var ( | ||
| // RecreateStrategyEventSources refers to the list of event source types | ||
| // that need to use Recreate strategy for its Deployment | ||
| RecreateStrategyEventSources = []EventSourceType{ |
There was a problem hiding this comment.
@VaibhavPage - Could you point me the right types here?
whynowy
commented
Jul 18, 2020
| @@ -76,7 +76,7 @@ func main() { | |||
| } | |||
| // A controller with DefaultControllerRateLimiter | |||
| c, err := controller.New(eventsource.ControllerName, mgr, controller.Options{ | |||
| Reconciler: eventsource.NewReconciler(mgr.GetClient(), mgr.GetScheme(), namespace, eventSourceImage, log.WithName("reconciler")), | |||
There was a problem hiding this comment.
This namespace is never used, remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recreatestrategy for some of the eventsources deployment update.a.) Event source with
rollingUpdateandrecreateare not allowed in one EventSource object - Otherwise when the EventSource is updated, there will be downtime for thoserollingUpdatetype event sources such aswebhook.b.) Event name (the map key) needs to be unique in one EventSource object, even different type of event source can not use same name - Because we use EventSourceName and EventName in Sensor as dependency.
c.)
rollingUpdatetypes use replicas defined in the spec, defaults to 1;d.)
recreateignores replica field in the spec, it always uses1Resourcetype EventSource.HDFSevent source - a bug ofconfigMapSelectortoenvFromconversion.Closes #752