Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for multiple types of event configuration within single eventsource #779

Closed
VaibhavPage opened this issue Jul 29, 2020 · 7 comments · Fixed by #815
Closed

Add docs for multiple types of event configuration within single eventsource #779

VaibhavPage opened this issue Jul 29, 2020 · 7 comments · Fixed by #815
Labels
enhancement New feature or request
Milestone

Comments

@VaibhavPage
Copy link
Contributor

No description provided.

@VaibhavPage VaibhavPage added the enhancement New feature or request label Jul 29, 2020
@VaibhavPage VaibhavPage added this to the v1.0 milestone Jul 29, 2020
@whynowy
Copy link
Member

whynowy commented Jul 29, 2020

It's been implemented in #755

Rules:

a.) Event source with rollingUpdate and recreate are not allowed in one EventSource object - Otherwise when the EventSource is updated, there will be downtime for those rollingUpdate type event sources such as webhook.
b.) Event name (the map key) needs to be unique in one EventSource object, even different type of event source can not use same name - Because we use EventSourceName and EventName in Sensor as dependency.
c.) rollingUpdate types use replicas defined in the spec, defaults to 1;
d.) recreate types ignore replica field in the spec, it always uses 1

@hisener
Copy link
Contributor

hisener commented Aug 4, 2020

Just for my understanding, would that allow something like the following?

apiVersion: argoproj.io/v1alpha1
kind: EventSource
metadata:
  name: event-source
spec:
  calendar:
    cron:
      interval: 10s
  github:
    webhook:
      ...

@VaibhavPage
Copy link
Contributor Author

@hisener yes, with the rules mentioned in the comment by @whynowy

@VaibhavPage
Copy link
Contributor Author

@whynowy we should add this in the documentation.

@VaibhavPage VaibhavPage changed the title Allow multiple types of event configuration within single eventsource Add docs for multiple types of event configuration within single eventsource Aug 4, 2020
@whynowy
Copy link
Member

whynowy commented Aug 4, 2020

Just for my understanding, would that allow something like the following?

apiVersion: argoproj.io/v1alpha1
kind: EventSource
metadata:
  name: event-source
spec:
  calendar:
    cron:
      interval: 10s
  github:
    webhook:
      ...

Bad example.... calendar is not allowed to be together with github....

@whynowy
Copy link
Member

whynowy commented Aug 4, 2020

@whynowy we should add this in the documentation.

I'll do that.

@hisener
Copy link
Contributor

hisener commented Aug 4, 2020

Bad example.... calendar is not allowed to be together with github....

Ah right, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants