Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InvocationType for AWS Lambda trigger #994

Closed
mrkwtz opened this issue Dec 17, 2020 · 3 comments
Closed

InvocationType for AWS Lambda trigger #994

mrkwtz opened this issue Dec 17, 2020 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@mrkwtz
Copy link

mrkwtz commented Dec 17, 2020

Is your feature request related to a problem? Please describe.
I want to make use of AWS Lambdas DeadLetterQueue feature for errors while processing async Lambda invocations. But right now it's not possible to do a async invocation while it could be.

Describe the solution you'd like
I'd like to have a InvocationType parameter in the Lambda trigger.

Describe alternatives you've considered
For this case it's all about error handling. When I execute a Lambda function and it fails I want to be able to act on it. It would be awesome if argo-events itself has this feature, but for now I don't see a way to handle failed triggers within argo-events.


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@mrkwtz mrkwtz added the enhancement New feature or request label Dec 17, 2020
@alexec
Copy link
Contributor

alexec commented Dec 17, 2020

Is this the case of adding an additional invoke input? Would you like to submit a PR?

@VaibhavPage
Copy link
Contributor

@mrkwtz can you explain your use-case when you say "acting on failed lambda"?

@mrkwtz
Copy link
Author

mrkwtz commented Mar 9, 2021

@VaibhavPage, sure. When you configure a DeadLetterQueue (DLQ) in a Lambda function, failed invocations go straight to this queue from where another process could pick them up and report them or try the same event again but maybe with a more resilient and failure tolerant second function. Unfortunately DLQs are only considered when you do an asynchronous invocation of a Lambda function. So the Lambda trigger has to be extended to support the additional parameter.

whynowy added a commit to whynowy/argo-events that referenced this issue Apr 22, 2021
@whynowy whynowy added this to the v1.4 milestone Apr 22, 2021
juliev0 pushed a commit to juliev0/argo-events that referenced this issue Mar 29, 2022
…#994 (argoproj#1187)

* feat(lambda-trigger): expose Lambda invocation type. Closes: argoproj#994

Signed-off-by: Derek Wang <[email protected]>

* example

Signed-off-by: Derek Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants