-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: kafka sasl auth #1186
feat: kafka sasl auth #1186
Changes from 6 commits
1f18505
543194d
71776e9
244e31a
9b8ad2f
5566e10
5201e2c
9210e92
0e377b9
c02fc33
0969441
f83f84d
17cbfc4
571569e
b072a95
f08d09f
4bee62d
ec5b99e
a3d7e3c
1c3a84c
9e364a4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -128,6 +128,21 @@ type TLSConfig struct { | |
DeprecatedClientKeyPath string `json:"clientKeyPath,omitempty" protobuf:"bytes,6,opt,name=clientKeyPath"` | ||
} | ||
|
||
// SASLConfig refers to SASL configuration for a client | ||
type SASLConfig struct { | ||
// SASLMechanism is the name of the enabled SASL mechanism. | ||
// Possible values: OAUTHBEARER, PLAIN (defaults to PLAIN). | ||
Mechanism string `json:"mechanism,omitempty" protobuf:"bytes,1,opt,name=mechanism"` | ||
// Version is the SASL Protocol Version to use | ||
// Kafka > 1.x should use V1, except on Azure EventHub which use V0 | ||
// User is the authentication identity (authcid) to present for | ||
// SASL/PLAIN or SASL/SCRAM authentication | ||
User *corev1.SecretKeySelector `json:"user,omitempty" protobuf:"bytes,2,opt,name=user"` | ||
// Password for SASL/PLAIN authentication | ||
Password *corev1.SecretKeySelector `json:"password,omitempty" protobuf:"bytes,3,opt,name=password"` | ||
// authz id used for SASL/SCRAM authentication | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where is authz id? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove authz id. It wasn't supposed to be in there. Comments were lifted from the sarama library. |
||
} | ||
|
||
// Backoff for an operation | ||
type Backoff struct { | ||
// The initial duration in nanoseconds or strings like "1s", "3m" | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments do not match the fields...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed comments.