Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(leaderelection): never give up connection retry to nats server #1748

Merged
merged 4 commits into from
Mar 23, 2022
Merged

fix(leaderelection): never give up connection retry to nats server #1748

merged 4 commits into from
Mar 23, 2022

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Mar 18, 2022 •
edited
Loading

Fixes: #1747

  1. The max auto reconnection to Nats server for Leader Election defaults to 60, changed to retry forever;
  2. If EventBus auth file is changed (e.g. the auth secret is deleted by mistake, the controller will regenerate a secret), let the eventsource and sensor pods restart to pick up the new auth file.

Signed-off-by: Derek Wang [email protected]

Checklist:

whynowy added 3 commits March 17, 2022 19:49
@whynowy
fix(leaderelection): never give up connection retry to nats server
190a9ff 
Signed-off-by: Derek Wang <[email protected]>
@whynowy
.
154685d 
Signed-off-by: Derek Wang <[email protected]>
@whynowy
.
1d09c1b 
Signed-off-by: Derek Wang <[email protected]>
@whynowy whynowy requested a review from alexec March 18, 2022 23:40
@whynowy whynowy requested a review from sarabala1979 March 23, 2022 21:30
@whynowy whynowy merged commit 9e9e90b into argoproj:master Mar 23, 2022
@whynowy whynowy deleted the leaderelection-endlessretry branch March 23, 2022 22:12
@tooptoop4
Copy link
Contributor

would be great to have a new release with this, helps fix #1547

@tooptoop4 tooptoop4 mentioned this pull request Mar 24, 2022
Closed
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
@whynowy
fix(leaderelection): never give up connection retry to nats server (a…
0686a5f 
…rgoproj#1748)

* fix(leaderelection): never give up connection retry to nats server

Signed-off-by: Derek Wang <[email protected]>

* .

Signed-off-by: Derek Wang <[email protected]>

* .

Signed-off-by: Derek Wang <[email protected]>
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
@whynowy
fix(leaderelection): never give up connection retry to nats server (a…
04ca064 
…rgoproj#1748)

* fix(leaderelection): never give up connection retry to nats server

Signed-off-by: Derek Wang <[email protected]>

* .

Signed-off-by: Derek Wang <[email protected]>

* .

Signed-off-by: Derek Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarabala1979 sarabala1979 sarabala1979 approved these changes

@alexec alexec Awaiting requested review from alexec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event loss by Event Source/Sensors after enabling HA (High Availability)
3 participants
@whynowy @tooptoop4 @sarabala1979