build: Make make lint faster
#1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <[email protected]>
alexec
commented
Mar 28, 2022
| @@ -8,16 +8,12 @@ jobs: | |||
| golangci: | |||
There was a problem hiding this comment.
copied from workflows, the action has it's own cache
alexec
commented
Mar 28, 2022
| @@ -139,12 +139,12 @@ start: image | |||
| kubectl -n argo-events wait --for=condition=Ready --timeout 60s pod --all | |||
|
|
|||
| $(GOPATH)/bin/golangci-lint: | |||
| curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b `go env GOPATH`/bin v1.44.0 | |||
alexec
commented
Mar 28, 2022
| @@ -29,4 +28,3 @@ linters: | |||
| - unused | |||
There was a problem hiding this comment.
I felt like there were a lot of linters, but lets see how it works
Signed-off-by: Alex Collins <[email protected]>
whynowy
approved these changes
Mar 28, 2022
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
Signed-off-by: Alex Collins <[email protected]>
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
Signed-off-by: Alex Collins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Collins [email protected]
Checklist: