Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set timeout and connection limit #284

Merged
merged 1 commit into from
May 15, 2019
Merged

Set timeout and connection limit #284

merged 1 commit into from
May 15, 2019

Conversation

anhdat
Copy link
Contributor

@anhdat anhdat commented May 15, 2019

Fix #283

Instead of using default HTTP Client, we should set timeout and connection limit.

Result:

The opening files stays at low:

while sleep 1; do lsof | grep gateway-c | wc -l; done

209
209
209
209
247
247
247
247
247
247
247
247
247
209
209
209
209

@anhdat anhdat changed the title Set timeout and and connection limit Set timeout and connection limit May 15, 2019
VaibhavPage
VaibhavPage approved these changes May 15, 2019
View reviewed changes
Copy link
Contributor

@VaibhavPage VaibhavPage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@VaibhavPage VaibhavPage merged commit c7d8b1e into argoproj:master May 15, 2019
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
@anhdat @VaibhavPage
Set timeout and and connection limit (argoproj#284)
e43c316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaibhavPage VaibhavPage VaibhavPage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Leaking connection
2 participants
@anhdat @VaibhavPage