Use authorized key parsing instead of reading binary certificates #3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: florian-feicht <[email protected]>
Signed-off-by: florian-feicht <[email protected]>
Signed-off-by: florian-feicht <[email protected]>
whynowy
reviewed
May 3, 2024
| @@ -303,7 +303,7 @@ type SFTPEventSource struct { | |||
| Username *corev1.SecretKeySelector `json:"username,omitempty" protobuf:"bytes,3,opt,name=username"` | |||
| // Password required for authentication if any. | |||
| Password *corev1.SecretKeySelector `json:"password,omitempty" protobuf:"bytes,4,opt,name=password"` | |||
| // SSHKeySecret refers to the secret that contains SSH key | |||
| // SSHKeySecret refers to the secret that contains SSH key. Key needs to contain private key and public key. | |||
There was a problem hiding this comment.
It changes to require both private and public keys?
There was a problem hiding this comment.
Actually the implementation required private and public key already. Only adjusted the comment to make it clear.
whynowy
approved these changes
May 20, 2024
| @@ -303,7 +303,7 @@ type SFTPEventSource struct { | |||
| Username *corev1.SecretKeySelector `json:"username,omitempty" protobuf:"bytes,3,opt,name=username"` | |||
| // Password required for authentication if any. | |||
| Password *corev1.SecretKeySelector `json:"password,omitempty" protobuf:"bytes,4,opt,name=password"` | |||
| // SSHKeySecret refers to the secret that contains SSH key | |||
| // SSHKeySecret refers to the secret that contains SSH key. Key needs to contain private key and public key. | |||
sysr9
pushed a commit
to sysr9/argo-events
that referenced
this pull request
May 21, 2024
…goproj#3113) Signed-off-by: florian-feicht <[email protected]> Signed-off-by: sysr9 <[email protected]>
whynowy
pushed a commit
that referenced
this pull request
Jun 14, 2024
) Signed-off-by: florian-feicht <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
The current implementation of the public key parsing a binary public key is needed (https://pkg.go.dev/golang.org/x/crypto/ssh#ParsePublicKey).
I would propose to switch to https://pkg.go.dev/golang.org/x/crypto/ssh#ParseAuthorizedKey as it supports a common string format, which is a lot easier to handle in secrets.
Example in go playground:
https://go.dev/play/p/doCqwWh6jpl