Add more EventSource event logs for failed to publish events #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whynowy
approved these changes
May 29, 2024
whynowy
pushed a commit
that referenced
this pull request
Jun 14, 2024
Signed-off-by: Derek Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Adds a debug log in the EventSource which logs the incoming event body with the CloudEvents event ID for better correlation in the EventSource. Also adds the CloudEvents EventID to the
Failed to publish an eventlog so we can actually know what event failed to publish to the EventBus. This ID was not available in that log before and when a failure occurred where the event failed to publish to the EventBus we were unable to pinpoint exactly what event failed to publish. This PR is meant to add more transparency to event failures in the EventSource so we have the ability to see what failed, similar to how we can debug the event in the Trigger.