Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rateLimit option to amqp gateway (#353) #378

Merged
merged 4 commits into from
Oct 21, 2019

Conversation

dgrisonnet
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2019

CLA assistant check
All committers have signed the CLA.

fayak
fayak previously approved these changes Oct 15, 2019
Copy link

@fayak fayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sweet

fayak
fayak previously approved these changes Oct 15, 2019
gateways/core/stream/amqp/config.go Outdated Show resolved Hide resolved
Copy link
Contributor

@VaibhavPage VaibhavPage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VaibhavPage VaibhavPage merged commit 70cca52 into argoproj:master Oct 21, 2019
@fayak fayak mentioned this pull request Oct 21, 2019
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
* Add rateLimit option to amqp gateway (argoproj#353)

Signed-off-by: Damien Grisonnet <[email protected]>

* Add ratePeriod option to amqp gateway

Signed-off-by: Damien Grisonnet <[email protected]>

* Fix period value

Signed-off-by: Damien Grisonnet <[email protected]>

* Fix errors import to keep the codebase consistent

Signed-off-by: Damien Grisonnet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants