fix: retry when connect to eventbus in sensor #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exherb
changed the title
|
|
whynowy
reviewed
Aug 5, 2020
There was a problem hiding this comment.
This is good, thanks for the PR, Would you please add the same to https://github.com/argoproj/argo-events/blob/master/eventsources/eventing.go#L259?
|
We already have a retry function at https://github.com/argoproj/argo-events/blob/master/eventsources/sources/util.go#L18, can you switch to use that? |
|
eventsource will crash and restart, so I think it’s ok to not retry connect when start? |
done |
juliev0
pushed a commit
to juliev0/argo-events
that referenced
this pull request
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when lots of sensors got updated, eventbus connect is really unstable.