Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Connect to git with InsecureIgnoreHostKey. Closes #841 #842

Merged
merged 2 commits into from
Aug 20, 2020

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Aug 20, 2020

Don't need to mount ~/.ssh/known_hosts to the POD any more to pull resources from git with git://xxxxx.

Closes #841

@whynowy whynowy requested a review from VaibhavPage August 20, 2020 05:59
Copy link
Contributor

@VaibhavPage VaibhavPage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

@VaibhavPage VaibhavPage merged commit db9a7f3 into argoproj:master Aug 20, 2020
@whynowy whynowy deleted the git_imp branch August 20, 2020 21:25
whynowy added a commit that referenced this pull request Aug 20, 2020
* feat: Connect to git with InsecureIgnoreHostKey. Closes #841

* fix test case failure
juliev0 pushed a commit to juliev0/argo-events that referenced this pull request Mar 29, 2022
…rgoproj#842)

* feat: Connect to git with InsecureIgnoreHostKey. Closes argoproj#841

* fix test case failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better approach to deal with ~/.ssh/known_hosts for triggers pulling resources from git.
2 participants