fix(argocd-notifications): Changes to rules RBAC role. (#697)

add role resourceNames argoproj-labs/argocd-notifications#199 allow configmap/secret list verb argoproj-labs/argocd-notifications#244 Signed-off-by: 1Psy <[email protected]>
argoproj · Apr 26, 2021 · 4e0bf1e · 4e0bf1e
1 parent 72f7192
commit 4e0bf1e
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 11 deletions.
diff --git a/charts/argocd-notifications/Chart.yaml b/charts/argocd-notifications/Chart.yaml
@@ -3,7 +3,7 @@ appVersion: 1.1.1
 description: A Helm chart for ArgoCD notifications, an add-on to ArgoCD.
 name: argocd-notifications
 type: application
-version: 1.1.2
+version: 1.1.3
 home: https://github.com/argoproj/argo-helm
 icon: https://raw.githubusercontent.com/argoproj/argo/master/docs/assets/argo.png
 keywords:

diff --git a/charts/argocd-notifications/templates/bots/slack/role.yaml b/charts/argocd-notifications/templates/bots/slack/role.yaml
@@ -5,23 +5,23 @@ metadata:
   name: {{ include "argocd-notifications.name" . }}-bot
 rules:
 - apiGroups:
-  - argoproj.io
+  - ""
   resources:
-  - applications
-  - appprojects
+  - secrets
+  - configmaps
   verbs:
   - get
   - list
   - watch
-  - update
-  - patch
 - apiGroups:
-  - ""
+  - argoproj.io
   resources:
-  - secrets
-  - configmaps
+  - applications
+  - appprojects
   verbs:
   - get
   - list
   - watch
+  - update
+  - patch
 {{ end }}
diff --git a/charts/argocd-notifications/templates/role.yaml b/charts/argocd-notifications/templates/role.yaml
@@ -19,9 +19,24 @@ rules:
 - apiGroups:
   - ""
   resources:
-  - secrets
   - configmaps
+  - secrets
   verbs:
-  - get
   - list
   - watch
+- apiGroups:
+  - ""
+  resourceNames:
+  - {{ include "argocd-notifications.name" . }}-cm
+  resources:
+  - configmaps
+  verbs:
+  - get
+- apiGroups:
+  - ""
+  resourceNames:
+  - {{ include "argocd-notifications.name" . }}-secret
+  resources:
+  - secrets
+  verbs:
+  - get