Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Spelling #563

Merged
merged 9 commits into from
Feb 2, 2021
Merged

chore: Spelling #563

merged 9 commits into from
Feb 2, 2021

Conversation

jsoref
Copy link
Member

@jsoref jsoref commented Jan 28, 2021

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@299fe87#commitcomment-46477627

The action reports that the changes in this PR would make it happy: f3179dd

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.


Checklist:

  • I have update the chart version in Chart.yaml following Semantic Versioning.
  • Any new values are backwards compatible and/or have sensible default.
  • I have followed the testing instructions in the contributing guide.
  • I have signed the CLA and the build is green.
  • I will test my changes again once merged to master and published.

Changes are automatically published when merged to master. They are not published on branches.


I'll update the chart versions once the content changes are deemed acceptable (and probably squash). I leave commits as distinct while reviewing because otherwise things get really painful.

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Copy link
Contributor

@spencergilbert spencergilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Have you looked at the failing CI, I think just fixing the semantic part is OK by me - doesn't seem like any of this Should fail the other CI

@jsoref

This comment has been minimized.

@jsoref jsoref changed the title Spelling chore: Spelling Feb 2, 2021
Signed-off-by: Josh Soref <[email protected]>
@yann-soubeyrand yann-soubeyrand merged commit 18fa697 into argoproj:master Feb 2, 2021
@jsoref jsoref deleted the spelling branch February 2, 2021 17:36
terrych0u pushed a commit to terrych0u/argo-helm that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants