-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Spelling #563
Merged
Merged
chore: Spelling #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref
requested review from
davidkarlsen,
seanson,
spencergilbert,
stefansedich,
vladlosev and
yann-soubeyrand
as code owners
January 28, 2021 17:34
spencergilbert
suggested changes
Feb 1, 2021
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
yann-soubeyrand
approved these changes
Feb 2, 2021
1 task
spencergilbert
approved these changes
Feb 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Have you looked at the failing CI, I think just fixing the semantic part is OK by me - doesn't seem like any of this Should fail the other CI
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Josh Soref <[email protected]>
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Sep 7, 2021
Signed-off-by: Josh Soref <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at jsoref@299fe87#commitcomment-46477627
The action reports that the changes in this PR would make it happy: f3179dd
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.
Checklist:
Chart.yaml
following Semantic Versioning.Changes are automatically published when merged to
master
. They are not published on branches.I'll update the chart versions once the content changes are deemed acceptable (and probably squash). I leave commits as distinct while reviewing because otherwise things get really painful.