Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(argo-events): update argo-events to 1.3.0 #678

Closed

Conversation

rory-lamendola
Copy link

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • I have updated the chart version in Chart.yaml following Semantic Versioning.
  • Any new values are backwards compatible and/or have sensible default.
  • I have followed the testing instructions in the contributing guide.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Changes are automatically published when merged to master. They are not published on branches.

Signed-off-by: rory.lamendola <[email protected]>
@rory-lamendola rory-lamendola force-pushed the rory/upgrade-argo-events branch from ec6204e to 12569e6 Compare April 15, 2021 16:14
@rory-lamendola rory-lamendola marked this pull request as ready for review April 15, 2021 16:15
Copy link
Contributor

@alecrajeev alecrajeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alecrajeev
Copy link
Contributor

To pass the Semantic Pull Request PR, may have to make the PR title and the latest commit be like this:
"chore(argo-events): update argo-events to 1.3.0"

@rory-lamendola rory-lamendola changed the title [argo-events] Upgrade to 1.3.0 chore(argo-events): update argo-events to 1.3.0 Apr 20, 2021
@rory-lamendola rory-lamendola force-pushed the rory/upgrade-argo-events branch from f6df2e6 to beeefa9 Compare April 20, 2021 15:21
…argo-helm into rory/upgrade-argo-events

Signed-off-by: rory.lamendola <[email protected]>
@rory-lamendola rory-lamendola force-pushed the rory/upgrade-argo-events branch from beeefa9 to 26fe4a1 Compare April 20, 2021 18:09
Copy link
Contributor

@alecrajeev alecrajeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I tested using 1.3.0 as the image tags and it was successful

@oliverbaehler
Copy link
Contributor

Hi @rory-lamendola, Thanks for your contribution. In order for this to be reviewed I need you to sign off all your commits (https://docs.github.com/en/github/authenticating-to-github/signing-commits). And Pull the latest State from the master branch. Thanks :)

@oliverbaehler
Copy link
Contributor

Resolved by #720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants