-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(argocd-notification): add context variable for templating purpose #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgavrylenko
changed the title
add context variable for templating purpose
feat (argocd-notification): add context variable for templating purpose
May 5, 2021
oliverbaehler
suggested changes
May 9, 2021
oliverbaehler
changed the title
feat (argocd-notification): add context variable for templating purpose
feat(argocd-notification): add context variable for templating purpose
May 9, 2021
Signed-off-by: Sergiy Gavrylenko <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]>
Signed-off-by: Sergiy Gavrylenko <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]>
…s from v1beta1 (#709) Signed-off-by: Jack Andersen <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]>
- add destinationrule to clusterrolebinding Signed-off-by: Hui Kang <[email protected]> Co-authored-by: Hui Kang <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]>
Signed-off-by: Alec Rajeev <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]>
Signed-off-by: Aniek Gul <[email protected]> Co-authored-by: Oliver Bähler <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]>
Co-authored-by: Oliver Bähler <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]>
Co-authored-by: Oliver Bähler <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]>
sgavrylenko
requested review from
cabrinha,
davidkarlsen,
jbehling,
seanson,
VaibhavPage and
yann-soubeyrand
as code owners
May 10, 2021 18:24
oliverbaehler
approved these changes
May 11, 2021
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Sep 7, 2021
argoproj#713) * add context variable for templating purpose Signed-off-by: Sergiy Gavrylenko <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * update version of argocd-notification chart Signed-off-by: Sergiy Gavrylenko <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * fix: spec.preserveUnknownFields must be set to false to allow upgrades from v1beta1 (argoproj#709) Signed-off-by: Jack Andersen <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * feat: add resources to argo-rollouts deployment (argoproj#711) - add destinationrule to clusterrolebinding Signed-off-by: Hui Kang <[email protected]> Co-authored-by: Hui Kang <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * chore(argo-events): update argo-events to 1.3.3 (argoproj#720) Signed-off-by: Alec Rajeev <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * chore(argo-cd): upgrade redis-ha version to 4.12.14 (argoproj#710) Signed-off-by: Aniek Gul <[email protected]> Co-authored-by: Oliver Bähler <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * Update charts/argocd-notifications/Chart.yaml Co-authored-by: Oliver Bähler <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> * Update charts/argocd-notifications/templates/configmap.yaml Co-authored-by: Oliver Bähler <[email protected]> Signed-off-by: Sergiy Gavrylenko <[email protected]> Co-authored-by: Sergiy Gavrylenko <[email protected]> Co-authored-by: jandersen-plaid <[email protected]> Co-authored-by: cskh <[email protected]> Co-authored-by: Hui Kang <[email protected]> Co-authored-by: Alec Rajeev <[email protected]> Co-authored-by: aniekgul <[email protected]> Co-authored-by: Oliver Bähler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Chart.yaml
following Semantic Versioning.Changes are automatically published when merged to
master
. They are not published on branches.