Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add button that links to docs to header #1086

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Apr 14, 2021

Signed-off-by: Remington Breeze [email protected]

Screen Shot 2021-04-14 at 2 20 11 PM

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

rbreeze added 3 commits April 14, 2021 14:20
Signed-off-by: Remington Breeze <[email protected]>
Signed-off-by: Remington Breeze <[email protected]>
@rbreeze rbreeze requested a review from alexmt April 14, 2021 21:27
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #1086 (bf9b021) into master (d9899f8) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1086      +/-   ##
==========================================
+ Coverage   81.22%   81.24%   +0.02%     
==========================================
  Files         103      103              
  Lines        9180     9192      +12     
==========================================
+ Hits         7456     7468      +12     
  Misses       1229     1229              
  Partials      495      495              
Impacted Files Coverage Δ
.../apis/rollouts/validation/validation_references.go 76.92% <0.00%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9899f8...bf9b021. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@rbreeze rbreeze merged commit 3a2936e into argoproj:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants