Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve and refactor validation for AnalysisTemplates #1117

Merged
merged 15 commits into from
May 10, 2021

Conversation

khhirani
Copy link
Contributor

@khhirani khhirani commented Apr 27, 2021

Refactor validation for AnalysisTemplates due to the Rollout spec changes made in #1015

Closes #872

Signed-off-by: khhirani [email protected]

@khhirani khhirani marked this pull request as draft April 27, 2021 02:26
@khhirani khhirani force-pushed the analysisrun-create-validation branch from e2a6732 to 67a2bb6 Compare May 5, 2021 19:58
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #1117 (28e6d27) into master (32bfe85) will decrease coverage by 0.05%.
The diff coverage is 86.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
- Coverage   81.05%   80.99%   -0.06%     
==========================================
  Files         105      105              
  Lines        9462     9473      +11     
==========================================
+ Hits         7669     7673       +4     
- Misses       1276     1282       +6     
- Partials      517      518       +1     
Impacted Files Coverage Δ
rollout/controller.go 75.98% <84.61%> (+0.40%) ⬆️
.../apis/rollouts/validation/validation_references.go 76.05% <88.46%> (+3.25%) ⬆️
utils/analysis/helpers.go 70.64% <100.00%> (ø)
rollout/analysis.go 80.60% <0.00%> (-3.05%) ⬇️
rollout/canary.go 77.93% <0.00%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32bfe85...28e6d27. Read the comment docs.

@khhirani khhirani marked this pull request as ready for review May 6, 2021 00:15
@khhirani khhirani requested a review from jessesuen May 6, 2021 00:16
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
24.8% 24.8% Duplication

@khhirani khhirani merged commit 4167357 into argoproj:master May 10, 2021
@khhirani khhirani deleted the analysisrun-create-validation branch May 10, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollout stuck in Progressing without aborting when (Cluster)AnalysisTemplate is missing required arg
2 participants