Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add workaround to fix 'stream terminated by RST_STREAM with error code: PROTOCOL_ERROR' #1862

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

alexmt
Copy link
Contributor

@alexmt alexmt commented Feb 11, 2022

Signed-off-by: Alexander Matyushentsev [email protected]

After upgrading grpc to 1.42.0 any REST API is failing with stream terminated by RST_STREAM with error code: PROTOCOL_ERROR error due to grpc-ecosystem/grpc-gateway#2447. The PR implement a workaround for this issue

…r code: PROTOCOL_ERROR'

Signed-off-by: Alexander Matyushentsev <[email protected]>
@alexmt alexmt requested review from jessesuen and rbreeze and removed request for jessesuen February 11, 2022 19:44
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.0% 5.0% Duplication

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #1862 (882b63c) into master (459112b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1862   +/-   ##
=======================================
  Coverage   82.36%   82.36%           
=======================================
  Files         119      119           
  Lines       16872    16872           
=======================================
  Hits        13897    13897           
  Misses       2284     2284           
  Partials      691      691           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 459112b...882b63c. Read the comment docs.

Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit d3c305c into argoproj:master Feb 12, 2022
@alexmt alexmt deleted the grp-api-fix branch February 12, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants