chore: Improve image build speed #1919

[34fathombelow]

Signed-off-by: Justin Marquis [email protected]

This is a follow-up to PR#1919. Cache created from the controller-image should be used to build the plugin-image. Buildx uses Buildkit under the hood and uses "Automatic garbage collection" which has a default policy of 10% of free disk space. Disabling the garbage collection ensures that the cache is temporarily stored for the duration of the runner.

I also made a small change to the Dockerfile to provide support for older versions of Docker and Podman which do not support multiple args on a single line.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

[codecov]

Codecov Report

Merging #1948 (5921b1c) into master (beae624) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1948      +/-   ##
==========================================
+ Coverage   82.42%   82.43%   +0.01%     
==========================================
  Files         119      119              
  Lines       16913    16913              
==========================================
+ Hits        13940    13943       +3     
+ Misses       2282     2280       -2     
+ Partials      691      690       -1     

Impacted Files	Coverage Δ
rollout/trafficrouting/istio/controller.go	52.43% <0.00%> (+1.62%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beae624...5921b1c. Read the comment docs.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[34fathombelow]

I noticed line# 66 of the Dockerfile we were compiling controller plugin plugin-linux plugin-darwin plugin-windows. There is no need to compile plugin-linux plugin-darwin plugin-windows binaries each time we build images, as they are not in any of the final images. They are only used during a release. With two different architectures being built, we were compiling six additional unneeded binaries. They are added back into the release workflow by including them as a --build-arg in /hack/build-release-plugins.sh

The release workflow now also supports all of the optimizations. Image build times should be about 10 minutes now!!! All these changes have been fully tested, I have ran them on GitHub runners, built images locally and verified images sizes and binaries work on both architectures.

Please add a label of "test-arm-image" to this PR.

[34fathombelow]

@harikrongali can you please review this when you get a chance?

[harikrongali]

@crenshaw-dev can you review?

[crenshaw-dev]

lgtm!

[alexmt]

thank you!