-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(controller): Add support for ephemeral metadata on BlueGreen rollouts. Fixes #973 #974
feat(controller): Add support for ephemeral metadata on BlueGreen rollouts. Fixes #973 #974
Conversation
Codecov Report
@@ Coverage Diff @@
## master #974 +/- ##
==========================================
+ Coverage 81.36% 81.38% +0.01%
==========================================
Files 100 101 +1
Lines 8844 8862 +18
==========================================
+ Hits 7196 7212 +16
- Misses 1180 1181 +1
- Partials 468 469 +1
Continue to review full report at Codecov.
|
Current status:
|
7ecce4f
to
3bd9954
Compare
This looks great!
DCO is sufficient. We've already moved off the CLA and will be disabling the bot.
There is a ongoing issue with e2e tests flaking because of
We often refer to it as: desired (aka active/preview) vs. stable. For documentation, I'm thinking we can replace the use of canary with desired, along with an explanation that desired means canary or preview depending on the strategy. |
The change looks straight forward and pretty much good to go. The e2e tests are not your fault so I think the only thing left to do is to update documentation. Please add in the documentation markdown, a note saying that this feature is a v1.0 feature so that < 0.10 users won't be confused when it doesn't work. e.g.:
|
Signed-off-by: cooperbenson-qz <cooper.benson@quizlet.com>
Signed-off-by: cooperbenson-qz <cooper.benson@quizlet.com>
Signed-off-by: cooperbenson-qz <cooper.benson@quizlet.com>
Signed-off-by: cooperbenson-qz <cooper.benson@quizlet.com>
Signed-off-by: cooperbenson-qz <cooper.benson@quizlet.com>
Signed-off-by: cooperbenson-qz <cooper.benson@quizlet.com>
Signed-off-by: cooperbenson-qz <cooper.benson@quizlet.com>
Signed-off-by: cooperbenson-qz <cooper.benson@quizlet.com>
Signed-off-by: cooperbenson-qz <cooper.benson@quizlet.com>
Signed-off-by: cooperbenson-qz <cooper.benson@quizlet.com>
Signed-off-by: cooperbenson-qz <cooper.benson@quizlet.com>
Signed-off-by: cooperbenson-qz <cooper.benson@quizlet.com>
Signed-off-by: cooperbenson-qz <cooper.benson@quizlet.com>
3bd9954
to
6edf5d0
Compare
Signed-off-by: cooperbenson-qz <cooper.benson@quizlet.com>
Signed-off-by: cooperbenson-qz <cooper.benson@quizlet.com>
90bb567
to
f9cd81a
Compare
Thanks for the suggestion for the documentation. Just pushed the update to the relevant docs page and took the opportunity to fix the link to USERS.md |
Signed-off-by: cooperbenson-qz <cooper.benson@quizlet.com>
30c510d
to
9d5bc25
Compare
Signed-off-by: cooperbenson-qz <cooper.benson@quizlet.com>
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job and appreciate the e2e test for this!
is this meant to say available in v.0.10? |
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.