Add autoPromotionEnabled with default value of true #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessesuen
reviewed
Jun 5, 2019
pkg/apis/rollouts/v1alpha1/types.go
Outdated
| // AutoPromoteEnabled indicates if the rollout should automatically promote the new ReplicaSet | ||
| // to the active service or enter a paused state. If not specified, the default value is true. | ||
| // +optional | ||
| AutoPromoteEnabled *bool `json:"autoPromoteEnabled,omitempty"` |
There was a problem hiding this comment.
We are inconsistent: AutoPromoteEnabled vs. AutoPromotionSeconds. To be consistent it should be: AutoPromotionEnabled
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
- Coverage 78.87% 78.83% -0.04%
==========================================
Files 15 15
Lines 1789 1800 +11
==========================================
+ Hits 1411 1419 +8
- Misses 279 281 +2
- Partials 99 100 +1
Continue to review full report at Codecov.
|
dthomson25
force-pushed
the
add-autoPromote
branch
from
4b78944 to
e69a3e4
Compare
jessesuen
changed the title
jessesuen
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #80