Skip to content

Commit

Permalink
chore: Remove uses of deprecated fields in docs and manifests (#5200)
Browse files Browse the repository at this point in the history
  • Loading branch information
terrytangyuan authored Mar 4, 2021
1 parent e56da57 commit 21a026b
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 14 deletions.
17 changes: 9 additions & 8 deletions docs/cost-optimisation.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,16 +107,17 @@ This above limit is suitable for the Argo Server, as this is stateless. The Work
> Suitable for all - unless you have large artifacts.
Configure [workflow-controller-configmap.yaml](workflow-controller-configmap.yaml) to set the `executorResources`
Configure [workflow-controller-configmap.yaml](workflow-controller-configmap.yaml) to set the `executor.resources`:

```yaml
executorResources:
requests:
cpu: 100m
memory: 64Mi
limits:
cpu: 500m
memory: 512Mi
executor: |
resources:
requests:
cpu: 100m
memory: 64Mi
limits:
cpu: 500m
memory: 512Mi
```

The correct values depend on the size of artifacts your workflows download. For artifacts > 10GB, memory usage may be large - [#1322](https://github.com/argoproj/argo-workflows/issues/1322).
3 changes: 1 addition & 2 deletions examples/gc-ttl.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# This example shows the ability to automatically delete workflows after a specified time period
# after the workflow completes. The TTLStrategy sets the strategy for how long workflows that are
# successful, not successful, or completed should live. The former ttlSecondsAfterFinished will be
# deprecated and will be replaced with TTLStrategy.SecondsAfterCompleted.
# successful, not successful, or completed should live.
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
Expand Down
1 change: 0 additions & 1 deletion manifests/quick-start-minimal.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,6 @@ data:
scope: sensor-logs
url: http://logging-facility?namespace=${metadata.namespace}&podName=${metadata.name}&startedAt=${status.startedAt}&finishedAt=${status.finishedAt}
metricsConfig: |
disableLegacy: true
enabled: true
path: /metrics
port: 9090
Expand Down
1 change: 0 additions & 1 deletion manifests/quick-start-mysql.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,6 @@ data:
scope: sensor-logs
url: http://logging-facility?namespace=${metadata.namespace}&podName=${metadata.name}&startedAt=${status.startedAt}&finishedAt=${status.finishedAt}
metricsConfig: |
disableLegacy: true
enabled: true
path: /metrics
port: 9090
Expand Down
1 change: 0 additions & 1 deletion manifests/quick-start-postgres.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,6 @@ data:
scope: sensor-logs
url: http://logging-facility?namespace=${metadata.namespace}&podName=${metadata.name}&startedAt=${status.startedAt}&finishedAt=${status.finishedAt}
metricsConfig: |
disableLegacy: true
enabled: true
path: /metrics
port: 9090
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ data:
name: my-minio-cred
key: secretkey
metricsConfig: |
disableLegacy: true
enabled: true
path: /metrics
port: 9090
Expand Down

0 comments on commit 21a026b

Please sign in to comment.