Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated docker executor #7795

Closed
Tracked by #7486 ...
alexec opened this issue Feb 7, 2022 · 7 comments · Fixed by #8212
Closed
Tracked by #7486 ...

Remove the deprecated docker executor #7795

alexec opened this issue Feb 7, 2022 · 7 comments · Fixed by #8212

Comments

@alexec
Copy link
Contributor

alexec commented Feb 7, 2022

Remove the executor code. Remove docker binary from executor.

@alexec alexec changed the title Remove the deprecated Docker executor Remove the deprecated docker executor Feb 7, 2022
@terrytangyuan terrytangyuan self-assigned this Feb 9, 2022
@terrytangyuan
Copy link
Member

This would also remove the gzip binary:

func getDockerCpCmd(containerID, sourcePath string, compressionLevel int, destPath string) string {

@blkperl
Copy link
Contributor

blkperl commented Mar 17, 2022

@alexec are we ready for PRs that remove this to be opened?

@alexec
Copy link
Contributor Author

alexec commented Mar 17, 2022

Yes please. Get on it!

@terrytangyuan
Copy link
Member

@blkperl I actually have something in progress locally but let me know if you’d like to work on it and I’ll re-assign to you.

@alexec
Copy link
Contributor Author

alexec commented Mar 17, 2022

We also need to remove other executors. Plenty for all.

@blkperl
Copy link
Contributor

blkperl commented Mar 17, 2022

@terrytangyuan I will grab a different one, I didn't notice you were assigned 👍🏻

@terrytangyuan
Copy link
Member

@blkperl Feel free to grab any in #7829 and re-assign to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants