-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non-Emissary executors #7829
Comments
This would depend on resolving any limitations of the Emissary executor. |
I think we can and should remove docker, k8sapi, and kublete executors. That would leave pns and emissary. |
Sounds good. I can start with those. |
I'd hold off for a few months. I don't think we want this until maybe v3.5. |
Wouldn't the removing part need to be done in a 4.0 release? We can add deprecation warnings in the logs and UI in the meantime though. |
I actually think we can and should do this without going v4.0. The executor you use really should be an implementation detail. The emissary should have feature parity with other executors. |
Just add a note here that we will also need to remove the functionality that allows using different executors. |
Some learnings from @alexec's POC for future reference: #7930 (comment) |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Bump |
Is there a transion guide? All my workflows are affected |
Okay, but how to fix the Workflows depending on another executor ;) |
It's a breaking change. Follow the two items related to emissary in https://github.com/argoproj/argo-workflows/blob/master/docs/upgrading.md#upgrading-to-v34 |
I'm having some issues with the default executor image, so I've git clone'd, added some debug lines to help me narrow down the problem and built a local container. How can I request that a workflow use my debug-enhanced container? |
docker
executor #7795k8sapi
executor #7802kubelet
executor #7803pns
executor #7804The text was updated successfully, but these errors were encountered: