-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Set default value to output parameters if suspend node timeout. Fixes #12230 #12960
Conversation
The |
…ixes argoproj#12230 Signed-off-by: oninowang <[email protected]>
seems all lint on new prs are failing:
|
Every PR has been failing the `make lint` checked with the following error since argoproj#12960 was merged: ``` assert.Equal(t, 1, len(status.Outputs.Parameters)) ^ Error: test/e2e/suspend_test.go:124:4: len: use assert.Len (testifylint) assert.Equal(t, 1, len(status.Inputs.Parameters)) ^ make: *** [Makefile:466: lint] Error 1 ``` This is happening due to a conflict between that PR and argoproj#13467. The latter PR was merged on August 14th, but the latest CI run for the former (https://github.com/argoproj/argo-workflows/actions/runs/9191558853/job/25278229097) was on May 22nd. Signed-off-by: Mason Malone <[email protected]>
@tooptoop4 I entered a PR to fix this: #13853 |
…ixes #12230 (#12960) Signed-off-by: oninowang <[email protected]> (cherry picked from commit 3df05eb)
@terrytangyuan @jswxstw Is there any chance to release a patch with the above fix? |
@kush-work I think this is a reasonable request, but I don't have the permission to do that. @Joibel Could you please take a look at this? |
Fixes #12230
Motivation
Node is marked to
Succeeded
when suspension is expired, but the value of node outputs parameters was not filled up withValueFrom.Default
ifValueFrom.Supplied != nil
.Modifications
Set default value to output parameters if suspend node timeout or mark the suspend node to error if raw output parameter has not been set and does not have a default value.
Verification
local test and add e2e test