fix: mark node failed if pod absent. Fixes #12993 #13454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
isubasinghe
changed the title
isubasinghe
commented
Aug 12, 2024
workflow/controller/taskresult.go
Outdated
| if foundPod { | ||
| woc.log.Debugf("Got pod %s with phase %s for task result %s and node id %s with label %s", pod.Name, pod.Status.Phase, resultName, result.Name, label) | ||
| woc.log.Debugf("The node phase was %s for node named %s", node.Phase, node.Name) | ||
| } else if !foundPod && !node.Completed() { |
There was a problem hiding this comment.
We could technically hit this case where a pod exists but hasn't made it to the cache yet.
Joibel
requested changes
Aug 12, 2024
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
Signed-off-by: isubasinghe <[email protected]>
Joibel
approved these changes
Aug 15, 2024
3 tasks
4 tasks
Closed
4 tasks
4 tasks
Joibel
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Sep 19, 2024
…3454) Signed-off-by: isubasinghe <[email protected]>
Joibel
pushed a commit
that referenced
this pull request
Sep 20, 2024
Signed-off-by: isubasinghe <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12993
Motivation
If the pod is absent and the node has not been completed, we should mark the node as failed after a timeout and mark the workflowtaskresult as completed.
Modifications
Verification