Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ARGO_TEMPLATE env var without inputs.parameters #13742

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

tooptoop4
Copy link
Contributor

Fixes #8790

Motivation

reduce etcd growth

Modifications

has env variable to maintain existing functionality for some users

@agilgur5 agilgur5 changed the title feat: argo_template env variable without inputs feat: ARGO_TEMPLATE env var without inputs Oct 12, 2024
@agilgur5 agilgur5 added area/controller Controller issues, panics area/executor labels Oct 12, 2024
@agilgur5 agilgur5 changed the title feat: ARGO_TEMPLATE env var without inputs feat: ARGO_TEMPLATE env var without inputs Oct 12, 2024
@tooptoop4 tooptoop4 requested a review from jswxstw October 12, 2024 09:35
@tooptoop4 tooptoop4 changed the title feat: ARGO_TEMPLATE env var without inputs feat: ARGO_TEMPLATE env var without inputs.parameters Oct 12, 2024
@juliev0
Copy link
Contributor

juliev0 commented Oct 14, 2024

Did you test it with both environment variable set "false" and unset?

@juliev0
Copy link
Contributor

juliev0 commented Oct 14, 2024

As a follow up to your various changes, would you be able to add to the docs the various ways that somebody can reduce their overall Pod size, including through offloading to a configmap?

@tooptoop4
Copy link
Contributor Author

tooptoop4 commented Oct 14, 2024

Did you test it with both environment variable set "false" and unset?

yes

As a follow up to your various changes, would you be able to add to the docs the various ways that somebody can reduce their overall Pod size, including through offloading to a configmap?

i can raise a follow up docs pr

@juliev0 juliev0 merged commit bf7760a into argoproj:main Oct 14, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Controller issues, panics area/executor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

duplicative env var ARGO_TEMPLATE result in etcd size 1MB limit
4 participants