Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reduce agent permissions. Fixes #7986 #7987

Merged
merged 9 commits into from
Feb 25, 2022
Merged

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Feb 23, 2022

Signed-off-by: Alex Collins [email protected]

Fixes #7986

Removing pod patch is not as useful, if the attacker can still create work using the task-set. This fixes that.

@alexec alexec requested a review from sarabala1979 February 24, 2022 00:56
@alexec alexec marked this pull request as ready for review February 24, 2022 00:56
@alexec alexec requested a review from jessesuen as a code owner February 24, 2022 00:56
@alexec alexec marked this pull request as draft February 24, 2022 00:56
@alexec alexec marked this pull request as ready for review February 24, 2022 01:56
@alexec
Copy link
Contributor Author

alexec commented Feb 24, 2022

@jessesuen can I get your rubber-stamp approval of the proto change? It is only adding status sub-resource

workflow/executor/agent.go Outdated Show resolved Hide resolved
@sarabala1979 sarabala1979 self-assigned this Feb 24, 2022
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
@alexec alexec changed the title fix!: Reduce agent permissions. Fixes #7986 fix: Reduce agent permissions. Fixes #7986 Feb 25, 2022
@alexec alexec enabled auto-merge (squash) February 25, 2022 01:30
Copy link
Member

@sarabala1979 sarabala1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexec alexec merged commit 06d4bf7 into argoproj:master Feb 25, 2022
@alexec alexec deleted the perm branch February 25, 2022 16:49
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
@agilgur5 agilgur5 added type/security Security related area/executor area/agent Argo Agent that runs for HTTP and Plugin templates area/manifests labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent Argo Agent that runs for HTTP and Plugin templates area/executor area/manifests type/security Security related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce agent permissions
3 participants