Skip to content

Commit

Permalink
fix: reduce chance of collision
Browse files Browse the repository at this point in the history
  • Loading branch information
gregberge committed Apr 1, 2018
1 parent f55e438 commit 14ed733
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 12 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@
"eslint": "^4.19.1",
"eslint-config-airbnb-base": "^12.1.0",
"eslint-config-prettier": "^2.9.0",
"eslint-plugin-import": "^2.9.0",
"eslint-plugin-import": "^2.10.0",
"express": "^4.16.3",
"jest": "^22.4.3",
"lerna": "^2.9.0",
"lerna": "^2.9.1",
"puppeteer": "^1.2.0",
"standard-version": "^4.3.0"
}
Expand Down
2 changes: 2 additions & 0 deletions packages/expect-puppeteer/src/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,7 @@ describe('expect-puppeteer', () => {
const main = await page.$('main')
expect(main).toBeDefined()
expect(main).not.toBe(null)

expect(200).toBe(200)
})
})
1 change: 1 addition & 0 deletions packages/expect-puppeteer/src/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export const getPuppeteerType = instance => {
instance &&
instance.constructor &&
instance.constructor.name &&
['Page', 'ElementHandle'].includes(instance.constructor.name) &&
instance.$
) {
return instance.constructor.name
Expand Down
20 changes: 10 additions & 10 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1678,23 +1678,23 @@ eslint-import-resolver-node@^0.3.1:
debug "^2.6.9"
resolve "^1.5.0"

eslint-module-utils@^2.1.1:
version "2.1.1"
resolved "https://registry.yarnpkg.com/eslint-module-utils/-/eslint-module-utils-2.1.1.tgz#abaec824177613b8a95b299639e1b6facf473449"
eslint-module-utils@^2.2.0:
version "2.2.0"
resolved "https://registry.yarnpkg.com/eslint-module-utils/-/eslint-module-utils-2.2.0.tgz#b270362cd88b1a48ad308976ce7fa54e98411746"
dependencies:
debug "^2.6.8"
pkg-dir "^1.0.0"

eslint-plugin-import@^2.9.0:
version "2.9.0"
resolved "https://registry.yarnpkg.com/eslint-plugin-import/-/eslint-plugin-import-2.9.0.tgz#26002efbfca5989b7288ac047508bd24f217b169"
eslint-plugin-import@^2.10.0:
version "2.10.0"
resolved "https://registry.yarnpkg.com/eslint-plugin-import/-/eslint-plugin-import-2.10.0.tgz#fa09083d5a75288df9c6c7d09fe12255985655e7"
dependencies:
builtin-modules "^1.1.1"
contains-path "^0.1.0"
debug "^2.6.8"
doctrine "1.5.0"
eslint-import-resolver-node "^0.3.1"
eslint-module-utils "^2.1.1"
eslint-module-utils "^2.2.0"
has "^1.0.1"
lodash "^4.17.4"
minimatch "^3.0.3"
Expand Down Expand Up @@ -3259,9 +3259,9 @@ left-pad@^1.2.0:
version "1.2.0"
resolved "https://registry.yarnpkg.com/left-pad/-/left-pad-1.2.0.tgz#d30a73c6b8201d8f7d8e7956ba9616087a68e0ee"

lerna@^2.9.0:
version "2.9.0"
resolved "https://registry.yarnpkg.com/lerna/-/lerna-2.9.0.tgz#303f70bc50b1c4541bdcf54eda13c36fe54401f3"
lerna@^2.9.1:
version "2.9.1"
resolved "https://registry.yarnpkg.com/lerna/-/lerna-2.9.1.tgz#d7d21793ad35ae7733733ced34ce30f5b3bb1abe"
dependencies:
async "^1.5.0"
chalk "^2.1.0"
Expand Down

0 comments on commit 14ed733

Please sign in to comment.