Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expect-puppeteer): enhance toMatchElement / toClick text option #57

Merged
merged 1 commit into from
May 3, 2018

Conversation

gregberge
Copy link
Member

BREAKING CHANGE: Text is now trimmed and no longer evaluated as a RegExp. If you want this behaviour, use a true RegExp.

Closes #51
Closes #50

BREAKING CHANGE: Text is now trimmed and no longer evaluated as a RegExp. If you want this behaviour, use a true RegExp.

Closes #51
Closes #50
@gregberge gregberge force-pushed the text-enhancement branch from 9058a1b to cee8f46 Compare May 3, 2018 09:37
@gregberge gregberge merged commit f4185da into master May 3, 2018
@gregberge gregberge deleted the text-enhancement branch May 3, 2018 09:40
@rkoval
Copy link
Contributor

rkoval commented May 3, 2018

awesome, thanks for implementing!

@gregberge
Copy link
Member Author

You are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants