Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Puppeteer v22 compatibility #576

Merged
merged 5 commits into from
Feb 10, 2024
Merged

Add Puppeteer v22 compatibility #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a2d416
chore: upgrade to Puppeteer v22 `devDependencies`
colinrotherham Feb 5, 2024
2926cff
docs: remove Puppeteer `headless: 'new'` option
colinrotherham Feb 5, 2024
bf9b0b3
fix: browser context compatibility in Puppeteer v22
colinrotherham Feb 5, 2024
e767103
chore: add Node.js v16 support to GitHub Actions
colinrotherham Feb 9, 2024
12a66c2
fix: use standard `shadowrootmode` attribute
colinrotherham Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [16, 18, "latest"]
node-version: [18, 20, "latest"]
gregberge marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ After installing Argos, learn how to [review visual changes](https://argos-ci.co
module.exports = {
launch: {
dumpio: true,
headless: process.env.HEADLESS !== "false" ? "new" : false,
headless: process.env.HEADLESS !== "false",
},
server: {
command: "node server.js",
Expand Down Expand Up @@ -213,7 +213,7 @@ Default config values:
module.exports = {
launch: {
dumpio: true,
headless: process.env.HEADLESS !== "false" ? "new" : false,
headless: process.env.HEADLESS !== "false",
product: "chrome",
},
browserContext: "default",
Expand Down
Loading
Loading