Sourcery Starbot ⭐ refactored arindas/mac-on-linux-with-qemu #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceryAI
commented
Feb 1, 2022
| plist_data = plist_raw.text.encode('UTF-8') | ||
| return plist_data | ||
| return plist_raw.text.encode('UTF-8') |
There was a problem hiding this comment.
Function Filesystem.fetch_plist refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-60
to
+63
| if sys.version_info > (3, 0): | ||
| root = plistlib.loads(catalog_data) | ||
| else: | ||
| root = plistlib.readPlistFromString(catalog_data) | ||
| return root | ||
| return ( | ||
| plistlib.loads(catalog_data) | ||
| if sys.version_info > (3, 0) | ||
| else plistlib.readPlistFromString(catalog_data) | ||
| ) |
There was a problem hiding this comment.
Function Filesystem.parse_plist refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-96
to
+112
| # Iterate to find valid OSInstall packages | ||
| ospackages = [] | ||
| products = root['Products'] | ||
| for product in products: | ||
| if products.get(product, {}).get('ExtendedMetaInfo', {}).get('InstallAssistantPackageIdentifiers', {}).get('OSInstall', {}) == 'com.apple.mpkg.OSInstall': | ||
| ospackages.append(product) | ||
|
|
||
| ospackages = [ | ||
| product | ||
| for product in products | ||
| if products.get(product, {}) | ||
| .get('ExtendedMetaInfo', {}) | ||
| .get('InstallAssistantPackageIdentifiers', {}) | ||
| .get('OSInstall', {}) | ||
| == 'com.apple.mpkg.OSInstall' | ||
| ] | ||
|
|
||
| # Iterate for an specific version | ||
| candidates = [] | ||
| for product in ospackages: | ||
| meta_url = products.get(product, {}).get('ServerMetadataURL', {}) | ||
| if self.version in Filesystem.parse_plist(Filesystem.fetch_plist(meta_url)).get('CFBundleShortVersionString', {}): | ||
| candidates.append(product) | ||
|
|
There was a problem hiding this comment.
Function SoftwareService.getosinstall refactored with the following changes:
- Move assignment closer to its usage within a block (
move-assign-in-block) - Convert for loop into list comprehension (
list-comprehension)
This removes the following comments ( why? ):
# Iterate to find valid OSInstall packages
Comment on lines
-123
to
+127
| if keyword: | ||
| for item in packages: | ||
| if keyword in item.get("URL"): | ||
| Filesystem.download_file(item.get("URL"), item.get("Size"), path) | ||
| else: | ||
| for item in packages: | ||
| for item in packages: | ||
| if keyword and keyword in item.get("URL") or not keyword: |
There was a problem hiding this comment.
Function MacOSProduct.fetchpackages refactored with the following changes:
- Hoist repeated code outside conditional statement (
hoist-statement-from-if) - Merge duplicate blocks in conditional (
merge-duplicate-blocks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run: