Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 337 - min image version #343

Merged
merged 6 commits into from
May 8, 2017
Merged

Conversation

jerearista
Copy link
Contributor

Closes #337. No behavior change unless the install_image attribute downgrade: false is set, in which case install_image will log a message and return if the existing image is equal to or newer than the action's configured image.

Copy link
Contributor

@dathelen dathelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Would it makes sense in the readthedocs documentation to mention the downgrade defaults to true. I see it in the docstrings so perhaps thats sufficient.

@jerearista
Copy link
Contributor Author

ReadTheDocs will pick up the docstring for the actions in docs/actions.rst. Added info to docs/cookbook/actions.rst

@jerearista jerearista merged commit 3af525d into develop May 8, 2017
@jerearista jerearista deleted the issue-337-min-image-version branch May 8, 2017 02:37
@jerearista jerearista modified the milestone: Release 1.5 May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants