Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature sockets #344

Merged
merged 7 commits into from
May 8, 2017
Merged

Feature sockets #344

merged 7 commits into from
May 8, 2017

Conversation

jerearista
Copy link
Contributor

Closes #336.
Default to using unix:sockets to communicate from the bootstrap client to EOS unless the image is too old.

dathelen
dathelen approved these changes May 8, 2017
View reviewed changes
Copy link
Contributor

@dathelen dathelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was thinking maybe as a future enhancement might be good to allow the user the configure the http localhost option as well. but thats a bit outside the scope of this change

@jerearista jerearista merged commit 4fcc17c into develop May 8, 2017
@jerearista jerearista deleted the feature-sockets branch May 8, 2017 20:13
@jerearista jerearista modified the milestone: Release 1.5 May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dathelen dathelen dathelen approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Release 1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@jerearista @dathelen