Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python3 update #382

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Python3 update #382

merged 1 commit into from
Jul 14, 2023

Conversation

dlobato
Copy link
Contributor

@dlobato dlobato commented Jun 30, 2023

Initial changes to port ztpserver to python3
#372

@dlobato dlobato requested a review from mharista June 30, 2023 13:50
mharista
mharista requested changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@mharista mharista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review

.gitignore Outdated Show resolved Hide resolved
client/bootstrap Show resolved Hide resolved
client/bootstrap Outdated Show resolved Hide resolved
mharista
mharista reviewed Jul 3, 2023
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@dlobato dlobato force-pushed the python3-update branch 3 times, most recently from d560148 to a07713c Compare July 5, 2023 16:43
mharista
mharista requested changes Jul 13, 2023
View reviewed changes
actions/add_config Outdated Show resolved Hide resolved
.pylintrc Outdated Show resolved Hide resolved
actions/copy_file Show resolved Hide resolved
actions/the_nick Outdated Show resolved Hide resolved
actions/send_email Outdated Show resolved Hide resolved
client/bootstrap Outdated Show resolved Hide resolved
client/bootstrap Outdated Show resolved Hide resolved
client/bootstrap Outdated Show resolved Hide resolved
ztpserver/app.py Show resolved Hide resolved
ztpserver/wsgiapp.py Show resolved Hide resolved
mharista
mharista approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@mharista mharista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlobato
Update codebase to python3
58ca749 
Fix unittests
Lint, code style and fstring conversion
Add pylint workflow
Add unittest workflow
@dlobato dlobato merged commit 084814e into develop Jul 14, 2023
@dlobato dlobato mentioned this pull request Jul 17, 2023
Closed
@dlobato dlobato deleted the python3-update branch August 25, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharista mharista mharista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlobato @mharista