Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force executing the bootstrap script with python3 if python runtime is available #398

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

dlobato
Copy link
Contributor

@dlobato dlobato commented Aug 24, 2023

No description provided.

@dlobato dlobato requested a review from mharista August 24, 2023 10:01
@dlobato dlobato force-pushed the bootstrap-detects-python3 branch from 49c49c8 to fead016 Compare August 24, 2023 10:03
@mharista
Copy link
Contributor

Just so I'm clear here. We only need the py3 re-execution in the boostrap and not in the actions because the actions are kicked off via the bootstrap? so it should already be running py3?

@dlobato
Copy link
Contributor Author

dlobato commented Aug 25, 2023

Exactly, actions are loaded dynamically from the bootstrap script. So whatever runtime the bootstrap script is running in, actions will also run in.

Copy link
Contributor

@mharista mharista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@dlobato dlobato merged commit ff80f92 into develop Aug 25, 2023
@dlobato dlobato deleted the bootstrap-detects-python3 branch August 25, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants