-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Remove CoffeeScript support #12410
Comments
Oh sad, this was really nice, in particular because CS had a standard library and sane stdin/stdout and command-line parsing, e.g. helpBanner = '''
PhantomJS drop-in for wkhtmltopdf and wkhtmltoimage by Aaron Stone
Usage: pjhtmltoimage [options] URL filename
'''
switches = [
['-h', '--help', 'Display help']
['-H', '--extended-help', 'Display more extensive help, detailing less common command switches']
['-V', '--version', 'Output version information an exit']
]
optparse = require ':/coffee-script/lib/coffee-script/optparse'
parser = new optparse.OptionParser switches, helpBanner
fs = require 'fs'
system = require 'system'
options = parser.parse system.args.slice 1
address = options.arguments[0]
output = options.arguments[1]
output = '/dev/stdout' if output is '-' https://github.com/sodabrew/pjhtmltopdf/blob/master/pjhtmltoimage.coffee |
@sodabrew You can still just compile the "optparse" Coffee to JS and require the external JS file instead. shrugs Pretty doubtful anything would change our mind on dropping it when all such compilation can just be handled ahead of time before invoking the main PhantomJS runner script. |
Closed by 48fabe0. |
I agree that it's the right thing from a maintenance overhead perspective, I'm only lamenting that I enjoyed the feature and I will miss it. Huge congratulations on landing Qt5 support - I am very excited for PhantomJS 2.0! I'll add a coffeescript make file to my project now ::|| |
Who doesn't like |
The website should really be updated to reflect this. |
@46bit Which website? phantomjs.org already has no reference to CoffeeScript. If there is still any, let me know. |
@ariya Apologies, I accidentally posted something for CasperJS here. |
This is to reduce maintenance burden since there is not much adoption of CoffeeScript among PhantomJS users. As a workaround, CoffeeScript users can still compile their scripts to JavaScript first before executing it with PhantomJS.
It will only affect PhantomJS >= 2.0.
The text was updated successfully, but these errors were encountered: