This repository has been archived by the owner on May 30, 2023. It is now read-only.
Improve Table Printing #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was part of a previous PhantomJS release but got reverted when the Qt source tree was imported. See the old pull request here: #211 http://code.google.com/p/phantomjs/issues/detail?id=880
This was already done in #211 but somehow got lost when the Qt source tree was imported. Note that I even improved this patch a bit to also properly repaint the borders of cells in thead/tfoot. http://code.google.com/p/phantomjs/issues/detail?id=615
|
Good catch, thank you! |
|
That pull request doesn't work if td has rowspan. something like this: http://jsfiddle.net/YJtg8/ |
This was referenced Mar 15, 2013
|
This issue appears to be fixed in release 1.8 but broken again in 1.9 :( |
|
@dpix, is this issue still broken in phantomjs 1.9.2? |
|
@dpix unfortunately it's still broken :( |
ariya
pushed a commit
that referenced
this pull request
Jan 7, 2014
This patch is taken from https://bugs.webkit.org/show_bug.cgi?id=5097#c17 It was originally part of PR #211 but was possibly overlooked in PR #344 (when the other two patches got reapplied after the QT source import).
|
@k31Sh1n The report is appreciated. Please help further. |
|
There's test-cases to reproduce bad thead positioning in this issue: |
|
Unfortunately problem still present. |
trygveaa
added a commit
to trygveaa/phantomjs
that referenced
this pull request
Jun 16, 2015
This has been done a few times before[0][1], but seems to be broken
again as reported in [2].
This commit is only reinstating what's missing from [1]. This was done
by running:
git log -p -1 2d778f6 | git apply -3 -p6 --directory=src/qt/qtwebkit
And resolving the conflicts. There are still some compile errors. These
will be fixed in the upcoming commits instead of in this one to clarify
the changes.
This change doesn't completely fix the issue. The thead/tfoot block is
drawn again on the next page, however the other content is not shifted
down accordingly. This means that the thead/tfoot block on the next page
will be placed on top of the continued table instead of above it.
[0]: ariya#211
[1]: ariya#344
[2]: ariya#13324
trygveaa
added a commit
to trygveaa/phantomjs
that referenced
this pull request
Jun 16, 2015
This has been done a few times before[0][1], but seems to be broken
again as reported in [2].
This commit is only reinstating what's missing from [1]. This was done
by running:
git log -p -1 2d778f6 | git apply -3 -p6 --directory=src/qt/qtwebkit
And resolving the conflicts. There are still some compile errors. These
will be fixed in the upcoming commits instead of in this one to clarify
the changes.
This change doesn't completely fix the issue. The thead block is drawn
again on the next page, however the other content is not shifted down
accordingly. This means that the thead block on the next page will be
placed on top of the continued table instead of above it. The tfoot
block is also repeated and seems to work as expected.
[0]: ariya#211
[1]: ariya#344
[2]: ariya#13324
trygveaa
added a commit
to trygveaa/phantomjs
that referenced
this pull request
Jun 16, 2015
This has been done a few times before[0][1], but seems to be broken
again as reported in [2].
This commit is only reinstating what's missing from [1]. This was done
by running:
git log -p -1 2d778f6 | git apply -3 -p6 --directory=src/qt/qtwebkit
And resolving the conflicts. There are still some compile errors. These
will be fixed in the upcoming commits instead of in this one to clarify
the changes.
[0]: ariya#211
[1]: ariya#344
[2]: ariya#13324
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapply the two table-printing related patches of #211 which apparently got lost when the Qt source tree was imported.
This solves the following two issues:
http://code.google.com/p/phantomjs/issues/detail?id=880
http://code.google.com/p/phantomjs/issues/detail?id=615
Example html page:
https://userpage.physik.fu-berlin.de/~milianw/phantomjs/printing/longtable.html
Example PDF output without patches:
https://userpage.physik.fu-berlin.de/~milianw/phantomjs/printing/longtable_vanilla.pdf
Example PDF output with both patches:
https://userpage.physik.fu-berlin.de/~milianw/phantomjs/printing/longtable_patched.pdf
Note: PDF output was created using the following command: