Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a number of changes:
PX
andSINI
parameters explicitly not rescaled. TheSINI
default setting is Uniform(0,1) and thePX
default setting checks to see if the lower bound is negative. If it is, then the lower bound is set to zero.nan
ofinf
was moved from thetm_delay
function to thetiming_block
function.enterprise.pulsar.Pulsar
object totiming_block
. This will be absolutely necessary if we using non-linear timing for more than one pulsar.timing_model
. This is the usual timing model.linear_timing_model
will denote the "special" kind of timing model.psr.tm_params_orig
dictionary added to theenterprise.pulsar.Pulsar
in thetiming_block
function. This negates the need to add it to theenterprise
software.linear_timing_model
when parameters are not otherwise modeled. This is the default behavior but can be turned off by settingfit_remaining_pars=False
.