Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function Changes #5

Merged
merged 3 commits into from
Oct 8, 2020
Merged

Function Changes #5

merged 3 commits into from
Oct 8, 2020

Conversation

Hazboun6
Copy link

@Hazboun6 Hazboun6 commented Oct 8, 2020

This PR includes a number of changes:

  • Made the PX and SINI parameters explicitly not rescaled. The SINI default setting is Uniform(0,1) and the PX default setting checks to see if the lower bound is negative. If it is, then the lower bound is set to zero.
  • The checking of nan of inf was moved from the tm_delay function to the timing_block function.
  • Some functionality necessitated the need for providing the enterprise.pulsar.Pulsar object to timing_block. This will be absolutely necessary if we using non-linear timing for more than one pulsar.
  • The name of the signal was changed to timing_model. This is the usual timing model. linear_timing_model will denote the "special" kind of timing model.
  • Added a draw from the timing model prior.
  • Added functionality to make the psr.tm_params_orig dictionary added to the enterprise.pulsar.Pulsar in the timing_block function. This negates the need to add it to the enterprise software.
  • Made the default width of the Uniform priors 5*sigma
  • Added functionality to use the linear_timing_model when parameters are not otherwise modeled. This is the default behavior but can be turned off by setting fit_remaining_pars=False.

@ark0015 ark0015 merged commit a64d1a0 into ark0015:ark-nltm Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants