Fix reading body failing with nil error #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshibuya
commented
Oct 23, 2022
| return nil, url | ||
| else | ||
| block&.call(response) | ||
| return response, nil |
There was a problem hiding this comment.
This use of using return within a block is the cause of the issue. It causes the execution to jump out from the method #fetch_once (not from this block), skipping post-processing of body read by net-http. So the result is attempting to read the body afterwards, when @socket already cleared up with nil.
|
@arkadiyt any input on this? |
|
@arkadiyt can you check this, please? |
shoe
approved these changes
Feb 3, 2023
arkadiyt
approved these changes
Sep 1, 2023
|
Sorry on the very long delay here, I'm getting back to this gem and going to maintain it more actively. Appreciate the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the issue #58, which was caused by #51.
@arkadiyt Please review this, many users are facing this issue.
carrierwaveuploader/carrierwave#2628