if greatest is selected, second coordinate should be picked (#495)

Co-authored-by: Pratyush Mishra <[email protected]>
arkworks-rs · Oct 16, 2022 · 09d3102 · 09d3102
1 parent ec6fc4d
commit 09d3102
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/ec/src/models/short_weierstrass/affine.rs b/ec/src/models/short_weierstrass/affine.rs
@@ -108,11 +108,11 @@ impl<P: SWCurveConfig> Affine<P> {
     /// largest y-coordinate be selected.
     #[allow(dead_code)]
     pub fn get_point_from_x_unchecked(x: P::BaseField, greatest: bool) -> Option<Self> {
-        Self::get_ys_from_x_unchecked(x).map(|(y, neg_y)| {
+        Self::get_ys_from_x_unchecked(x).map(|(smaller, larger)| {
             if greatest {
-                Self::new_unchecked(x, y)
+                Self::new_unchecked(x, larger)
             } else {
-                Self::new_unchecked(x, neg_y)
+                Self::new_unchecked(x, smaller)
             }
         })
     }