Skip to content

Commit

Permalink
fix: normalize git show signature option to false (conventional-chang…
Browse files Browse the repository at this point in the history
…elog#671)

This disables `git log` showing signatures (`--no-show-signature`)
unless `showSignature` is set to a truthy value.  This way differences
in developers` local configuration (`log.showSignature`) do not affect
tooling operation.  Callers of `gitRawCommits` will need to explicitly
request signatures (via `rawGitOpts`) if they are desired, instead of
the current behavior of the presence of signatures being undefined.

Fixes conventional-changelog/commitlint#2118

Co-authored-by: Benjamin E. Coe <[email protected]>
  • Loading branch information
thesmiley1 and bcoe authored Dec 29, 2020
1 parent a11026c commit a0b348c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/git-raw-commits/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ function normalizeGitOpts (gitOpts) {
gitOpts = gitOpts || {}
gitOpts.format = gitOpts.format || '%B'
gitOpts.from = gitOpts.from || ''
gitOpts.showSignature = gitOpts.showSignature || false
gitOpts.to = gitOpts.to || 'HEAD'
return gitOpts
}
Expand Down

0 comments on commit a0b348c

Please sign in to comment.