Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--save-exact for npm install isn't converted correctly #7

Closed
favna opened this issue Jul 11, 2022 · 1 comment · Fixed by nebrelbug/npm-to-yarn#36
Closed

--save-exact for npm install isn't converted correctly #7

favna opened this issue Jul 11, 2022 · 1 comment · Fixed by nebrelbug/npm-to-yarn#36

Comments

@favna
Copy link

favna commented Jul 11, 2022

Describe the bug
I found this fork through your contribution to Docusaurus. Seeing as the source repository appears to be dead I'm creating the issue here hoping you can fix this.

There is currently a bug with npm install pkg --save-exact getting converted to yarn add pkg-exact instead of yarn add pkg --exact

To Reproduce
Steps to reproduce the behavior:

  1. Pass npm install pkg --save-exact to the npm-to-yarn with second argument set to yarn
  2. Observe result

Expected behavior
Gets converted to yarn add pkg --exact

Package & Environment Details

  • Environment: Node v18.4.0
  • Version: 1.1.1

Additional context
N.A.
favna added a commit to favna/npm-to-yarn that referenced this issue Jul 11, 2022
@favna
fix: make sure --save-exact is converted correctly
2cddbdd 
Fixes armano2#7 

Funny how these things go. I reported the issue then I started fixing a similar issue for npm to pnpm for sapphiredev/documentation-plugins#80 and turns out this fix also works for npm to yarn

Example regexr: regexr.com/6phbp
@favna favna mentioned this issue Jul 11, 2022
Closed
armano2 added a commit that referenced this issue Feb 12, 2023
@armano2
fix: add test cases for reported issues
bcef280 
- #6
- #7
This was referenced Feb 12, 2023
Merged
Merged
@armano2
Copy link
Owner

armano2 commented Feb 19, 2023

fixed in npm-to-yarn

@armano2 armano2 closed this as completed Feb 19, 2023
@jimmyn jimmyn mentioned this issue Aug 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@armano2 @favna