Lua 5.4 non-wrapping decimal literals #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Lua 5.4 they no longer wrap but turn to floats instead
cderici
approved these changes
Jan 12, 2022
Codecov Report
@@ Coverage Diff @@
## lua5.4 #50 +/- ##
=======================================
Coverage 86.83% 86.83%
=======================================
Files 93 93
Lines 10073 10073
=======================================
Hits 8747 8747
Misses 1043 1043
Partials 283 283 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Lua < 5.4, decimal literals would wrap if they overflowed. In 5.4 they are converted to floats.
Golua was already doing this (probably because the behaviour was previously not specified), so this PR only adds some tests.